Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TS 4.7 Instantiation Expressions for filterObject return type #806

Merged

Conversation

nelsonni
Copy link
Member

@nelsonni nelsonni commented Jun 7, 2022

Description:

#787 updated typescript to 4.7, which includes Instantiation Expressions, allowing us to update the return type of filterObject() to use a pass-through generic reference T for discerning the expected return based on the actual return type of flattenObject (as outlined in #699).

This PR resolves #699, and signifies a MINOR version increase (per Semantic Version).

Changes:

This PR makes the following changes:

  • Updates filterObject() to use ReturnType<typeof flattenObject<T>> for indicating that all

Checklist:

Before submitting this PR, I have verified that my code:

  • Resides on a fix/ or feature/ branch that was initially branched off from development.
  • Passes code linting (yarn lint) and unit testing (yarn test).
  • Successfully builds a distribution package (yarn package).
  • I have read and am aware of the CONTRIBUTING guide for this project.
  • My name is listed in the Contributors section, or this PR includes a request to add my name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports or bug fixes feature Feature requests or improvements
Projects
None yet
1 participant